Use whole button (commit graph) as link #1390
Conversation
Morlinest
changed the title
|
\cc @geek1011 @Fastidious |
|
It would help if this was accompanied by a screenshot. You know, "an image is worth..." |
tboerger
added
the
lgtm/need 2
|
@Fastidious Sure, updated with screenshots. Hope its clear now. Thx. |
lunny
added
type/enhancement
|
@Morlinest thanks. |
| @@ -5,14 +5,12 @@ | |||
| <div class="ui secondary menu"> | |||
| {{template "repo/branch_dropdown" .}} | |||
| <div class="fitted item"> | |||
| <div class="ui basic small button"> | |||
There was a problem hiding this comment.
I think this div should not be removed, just the class.
There was a problem hiding this comment.
Do we need div without any attributes just to wrap one element? Inspired by menu/list (no problem to change, tested with div and works same).
There was a problem hiding this comment.
I mean, you removed the head <div> but not the tail </div>.
I think it's okay to remove, though.
There was a problem hiding this comment.
I think I removed both div tags and moved class attribute from div to a. Am I missing something? I did not do formatting so the change stays clear.
There was a problem hiding this comment.
Oh, sorry. I think I looked too fast.
|
LGTM |
tboerger
removed
the
lgtm/need 2
|
LGTM |
tboerger
added
the
lgtm/done
|
Thank you very much |
Update html template to use whole button as link, not only text inside button.
Before:
After:
