Skip to content

Use whole button (commit graph) as link #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Use whole button (commit graph) as link #1390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions templates/repo/commits.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
<div class="ui secondary menu">
{{template "repo/branch_dropdown" .}}
<div class="fitted item">
<div class="ui basic small button">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this div should not be removed, just the class.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need div without any attributes just to wrap one element? Inspired by menu/list (no problem to change, tested with div and works same).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, you removed the head <div> but not the tail </div>.

I think it's okay to remove, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed both div tags and moved class attribute from div to a. Am I missing something? I did not do formatting so the change stays clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. I think I looked too fast.

<a href="{{.RepoLink}}/graph">
<a href="{{.RepoLink}}/graph" class="ui basic small button">
<span class="text">
<i class="octicon octicon-git-branch"></i>
</span>
{{.i18n.Tr "repo.commit_graph"}}
</a>
</div>
</div>
</div>
{{template "repo/commits_table" .}}
Expand Down