Skip to content

debug dlvdap: clean up package.json to fit the new DA #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eliben opened this issue Jun 30, 2020 · 3 comments
Closed

debug dlvdap: clean up package.json to fit the new DA #271

eliben opened this issue Jun 30, 2020 · 3 comments
Labels
FrozenDueToAge

Comments

@eliben
Copy link
Member

eliben commented Jun 30, 2020

Follow up on package.json suggestions in the review: #267
@eliben eliben mentioned this issue Jun 30, 2020
Closed
@polinasok
Copy link
Contributor

Also don't need "rpc" as a logOutput option in dap mode.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/240417 mentions this issue: debug: implement new prototype thin DA for delve

gopherbot pushed a commit that referenced this issue Jul 1, 2020
@eliben @hyangah
debug: implement new prototype thin DA for delve
17d0045 
Updates #23

This DA serves as a DAP proxy between the editor and a DAP-capable Delve. Right now all it does is launch Delve (in DAP mode) when LaunchRequest is received from the editor, and then relays all messages between the editor and Delve back and forth.

package.json section is copied from the current DA as-is. Some of its options will be removed and cleaned up in the subsequent PRs to make the diffs more obvious (see #271).

Change-Id: I3493c5ee1d9e80071a17ea32c04a15eb021c8006
GitHub-Last-Rev: ddd68dc
GitHub-Pull-Request: #267
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240417
Reviewed-by: Polina Sokolova <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
@eliben eliben mentioned this issue Jul 6, 2020
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/241097 mentions this issue: debug: remove unnecessary settings from package.json of debugAdapter2

@golang golang locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debug: remove unnecessary settings from package.json of debugAdapter2
3 participants
@eliben @gopherbot @polinasok