debug: implement new prototype thin DA for delve

[eliben]

Updates #23

This DA serves as a DAP proxy between the editor and a DAP-capable Delve. Right now all it does is launch Delve (in DAP mode) when LaunchRequest is received from the editor, and then relays all messages between the editor and Delve back and forth.

package.json section is copied from the current DA as-is. Some of its options will be removed and cleaned up in the subsequent PRs to make the diffs more obvious (see #271).

[gopherbot]

This PR (HEAD: b979615) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: e200bcb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[eliben]

@polinasok FYI

I'm still cleaning up this PR. Reverted package-lock, and now looking at some extra configs that sneaked into package.json

[eliben]

After looking deeper into the package.json diff, it seems to be an artifact of how the review tool understands the diff (I added a large config section which duplicates information with a similar one); the Gerrit tool shows the diff differently but also somewhat confusingly. At the end of the day, the PR just adds a new debugger mode for Go called "godlvdap"

[gopherbot]

This PR (HEAD: 37df287) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[eliben]

npm run lint is clean now

[gopherbot]

This PR (HEAD: a0dedd0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: b2f6ab4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Polina Sokolova:

Patch Set 6:

(3 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Hyang-Ah Hana Kim:

Patch Set 6: Run-TryBot+1

(5 comments)

Thanks!

Wonder how you like shorter directory/file names. Something like debugAdapter2 instead of debugAdapterDlvDap (and document it means the version that uses dlv dap),
and dapClient.ts, goDebug.ts, goDebugMain.ts as file names.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Eli Bendersky:

Patch Set 6:

Patch Set 6: Run-TryBot+1

(5 comments)

Thanks!

Wonder how you like shorter directory/file names. Something like debugAdapter2 instead of debugAdapterDlvDap (and document it means the version that uses dlv dap),
and dapClient.ts, goDebug.ts, goDebugMain.ts as file names.

I don't mind the name very much. One issue with goDebug.ts is that it's the same name as the current DA, so two files with the same name, in different dirs. This makes it hard to distinguish them in open tabs in the editor, for example.

Since the long-term maintenance of this DA will be in your team, I'll completely defer to your choice of file names here. If what I mentioned in the previous paragraph is not a concern, I'll rename to that.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Hyang-Ah Hana Kim:

Patch Set 6:

Patch Set 6:

Patch Set 6: Run-TryBot+1

(5 comments)

Thanks!

Wonder how you like shorter directory/file names. Something like debugAdapter2 instead of debugAdapterDlvDap (and document it means the version that uses dlv dap),
and dapClient.ts, goDebug.ts, goDebugMain.ts as file names.

I don't mind the name very much. One issue with goDebug.ts is that it's the same name as the current DA, so two files with the same name, in different dirs. This makes it hard to distinguish them in open tabs in the editor, for example.

Since the long-term maintenance of this DA will be in your team, I'll completely defer to your choice of file names here. If what I mentioned in the previous paragraph is not a concern, I'll rename to that.

Thanks, let's rename the directory to debugAdapter2 for sure. If goDebug.ts is too confusing, I am fine with other name of your choice as long as it's not too long.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 30a337d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 41d6bad) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: a547234) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Eli Bendersky:

Patch Set 9:

(6 comments)

Patch Set 6:

Patch Set 6:

Patch Set 6: Run-TryBot+1

(5 comments)

Thanks!

Wonder how you like shorter directory/file names. Something like debugAdapter2 instead of debugAdapterDlvDap (and document it means the version that uses dlv dap),
and dapClient.ts, goDebug.ts, goDebugMain.ts as file names.

I don't mind the name very much. One issue with goDebug.ts is that it's the same name as the current DA, so two files with the same name, in different dirs. This makes it hard to distinguish them in open tabs in the editor, for example.

Since the long-term maintenance of this DA will be in your team, I'll completely defer to your choice of file names here. If what I mentioned in the previous paragraph is not a concern, I'll rename to that.

Thanks, let's rename the directory to debugAdapter2 for sure. If goDebug.ts is too confusing, I am fine with other name of your choice as long as it's not too long.

Renamed

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Eli Bendersky:

Patch Set 10:

Thank you for all the comments. I hope I covered everything - with the Gerrit/GitHub split and all the renamed files it's becoming a bit challenging to track. Please let me know if I missed anything

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Hyang-Ah Hana Kim:

Patch Set 11:

(4 comments)

I will let Polina do the final LGTM :-)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Polina Sokolova:

Patch Set 11:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 25734e2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Eli Bendersky:

Patch Set 11:

(3 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Polina Sokolova:

Patch Set 12:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Eli Bendersky:

Patch Set 12:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 0eef564) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Eli Bendersky:

Patch Set 12:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: ddd68dc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240417 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Eli Bendersky:

Patch Set 13:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Eli Bendersky:

Patch Set 14:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Polina Sokolova:

Patch Set 14: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Polina Sokolova:

Patch Set 14:

LGTM

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Hyang-Ah Hana Kim:

Patch Set 14: Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/240417.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/240417 has been merged.