debug: more robust wait for server to listen to socket #291
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: f5e48d1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241117 to see it. Tip: You can toggle comments from me using the |
|
Message from Hyang-Ah Hana Kim: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/241117. |
|
This PR (HEAD: 13c423a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/241117 to see it. Tip: You can toggle comments from me using the |
|
Message from Eli Bendersky: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/241117. |
|
Message from Hyang-Ah Hana Kim: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/241117. |
Take the waiting code from the existing adapter - try to connect after server emits to stdout. Also add comment in dapClient.ts for clarity. Updates #23 Follow up on #267 Change-Id: I29d0c87504464ce2ad0297ec0a5d7ad67c707b88 GitHub-Last-Rev: 13c423a GitHub-Pull-Request: #291 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/241117 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
|
This PR is being closed because golang.org/cl/241117 has been merged. |
Take the waiting code from the existing adapter - try to connect after server emits to stdout. Also add comment in dapClient.ts for clarity.
Updates #23
Follow up on #267