-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove v1 exclusion configuration #5451
Conversation
9cf68b2
to
78a202e
Compare
1a79d23
to
82aaf0d
Compare
82aaf0d
to
9f01ded
Compare
5958c0e
to
538fb13
Compare
009e288
to
7dc37de
Compare
7dc37de
to
3214cac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor grammar improvements.
.golangci.next.reference.yml
Outdated
- comments | ||
- stdErrorHandling | ||
- commonFalsePositives | ||
- legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better is to use -
as a delimiter between words instead of camelCase?
- comments | |
- stdErrorHandling | |
- commonFalsePositives | |
- legacy | |
- comments | |
- std-error-handling | |
- common-false-positives | |
- legacy |
Or make preset names shorter with an extended description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to use camelCase because these are not field names.
And I want human-readable names, this is explained inside the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I can vote, I vote to use kebab-case for human readable names. camelCase lacks the space usually seen in text and feels more aimed towards computers, similar with snake_case and underscore.
I know these are values and not keys, but we do use kebab-case in general in the config (e.g. disable-all
and disable-dec-order-check
) which I thought was because it was preferred (it is for me) and if so I suggest using the same convention for these values as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change the values but we agree those values have been documented inside the proposal and introduced by another PR. This PR is just adding them to the documentation.
My remark about human-readable names was related to the idea "make preset names shorter with an extended description", because I want to avoid the previous "short but unusable without the doc" names.
f60e5e1
to
7b39825
Compare
Fixes #5298
Fixes #456