Skip to content

Update release mode flag #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stuartmorgan-g
Copy link
Collaborator

The Flutter engine renamed the flag that controls the "Debug" banner
as part of the Dart 2 transition (Engine PR 6977). Update the example
apps to pass the new flag in release mode.

The Flutter engine renamed the flag that controls the "Debug" banner
as part of the Dart 2 transition (Engine PR 6977). Update the example
apps to pass the new flag in release mode.
@stuartmorgan-g
Copy link
Collaborator Author

We may want to change this to be internal to the framework, rather than a string that each embedder implementation has to manage, but IIRC there are plans to change the Engine's argument API so I'll wait to see what happens there before making structural changes.

Copy link
Contributor

@krisgiesing krisgiesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g merged commit 67cbda5 into google:master Jan 3, 2019
@stuartmorgan-g stuartmorgan-g deleted the update-dart-assert-flag branch January 8, 2019 18:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants