Skip to content

Update release mode flag #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Debugging.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ There are two options:
1. **Hard-code the port**. In your embedder code, add `--observatory-port=49494`
(substituting a port of your choice) to the list of arguments passed to the
engine. If you are using `example/`, or code based on it, look for the
line that adds `--dart-non-checked-mode` for an example of adding arguments.
line that adds `--disable-dart-asserts` for an example of adding arguments.
(Be sure not to add the `observatory-port` argument inside the `#if`,
however.)

Expand Down
2 changes: 1 addition & 1 deletion example/linux/flutter_embedder_example.cc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ int main(int argc, char **argv) {
// args.
arguments.push_back(argv[0]);
#ifdef NDEBUG
arguments.push_back("--dart-non-checked-mode");
arguments.push_back("--disable-dart-asserts");
#endif
// Start the engine.
auto window = flutter_desktop_embedding::CreateFlutterWindowInSnapshotMode(
Expand Down
2 changes: 1 addition & 1 deletion example/macos/ExampleWindow.swift
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class ExampleWindow: NSWindow {
// command line string.
var arguments = [CommandLine.arguments[0]];
#if !DEBUG
arguments.append("--dart-non-checked-mode");
arguments.append("--disable-dart-asserts");
#endif
flutterViewController.launchEngine(
withAssetsPath: assets,
Expand Down
2 changes: 1 addition & 1 deletion example/windows/flutter_embedder_example.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ int main(int argc, char **argv) {
// args.
arguments.push_back(argv[0]);
#ifndef _DEBUG
arguments.push_back("--dart-non-checked-mode");
arguments.push_back("--disable-dart-asserts");
#endif
// Start the engine.
// TODO: Make paths relative to the executable so it can be run from anywhere.
Expand Down