-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove custom media type for Repository Invitations API #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @gmlewis Can I take this? |
I just talked to @willnorris who reminded me that we will not be removing any features until we get confirmation that the removal won't break Enterprise API clients... so please hold off on addressing this issue. Also, semantic versioning, once we nail that down for this repo, should assist with this situation. |
Sure @gmlewis |
I can take this up next if @RaviTezu is not currently working on it. |
Please see my comment above. We need confirmation from GitHub Enterprise API customers that the removal will not break them, which has happened in the past. Alternatively, semantic versioning needs to be adhered to in this repo before proceeding with this issue. |
@gmlewis is this issue still blocked? If not I would like to work on this. |
This issue is no longer blocked thanks to versioning. Feel free to take it, @knrt10. |
Would you please assign me. |
You first need to be sent an invite, @knrt10, and @willnorris can send you one when he has a chance. In the meantime, however, please consider this issue to be assigned to you. |
GitHub Announcement:
https://developer.github.com/changes/2017-08-23-repository-invitation-api/
The custom media type
mediaTypeRepositoryInvitationsPreview
that was added in #373 can now be removed as it is no longer necessary.Edit: ~~~GitHub Enterprise API customers may wish to comment on this issue if they feel that this removal should be delayed for any reason.~~~
The text was updated successfully, but these errors were encountered: