Skip to content

Remove custom media type for Repository Invitations API #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gmlewis opened this issue Aug 24, 2017 · 9 comments
Closed

Remove custom media type for Repository Invitations API #708

gmlewis opened this issue Aug 24, 2017 · 9 comments

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 24, 2017

GitHub Announcement:
https://developer.github.com/changes/2017-08-23-repository-invitation-api/

The custom media type mediaTypeRepositoryInvitationsPreview that was added in #373 can now be removed as it is no longer necessary.

Edit: ~~~GitHub Enterprise API customers may wish to comment on this issue if they feel that this removal should be delayed for any reason.~~~

@RaviTezu
Copy link
Contributor

Hi @gmlewis Can I take this?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 24, 2017

I just talked to @willnorris who reminded me that we will not be removing any features until we get confirmation that the removal won't break Enterprise API clients... so please hold off on addressing this issue.

Also, semantic versioning, once we nail that down for this repo, should assist with this situation.

See #376, #617, and #638 for further discussion.

@RaviTezu
Copy link
Contributor

Sure @gmlewis

@kshitij10496
Copy link
Contributor

I can take this up next if @RaviTezu is not currently working on it.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 19, 2017

Please see my comment above. We need confirmation from GitHub Enterprise API customers that the removal will not break them, which has happened in the past. Alternatively, semantic versioning needs to be adhered to in this repo before proceeding with this issue.

@knrt10
Copy link
Contributor

knrt10 commented Dec 11, 2018

@gmlewis is this issue still blocked? If not I would like to work on this.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 11, 2018

This issue is no longer blocked thanks to versioning. Feel free to take it, @knrt10.

@knrt10
Copy link
Contributor

knrt10 commented Dec 11, 2018

Would you please assign me.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 11, 2018

You first need to be sent an invite, @knrt10, and @willnorris can send you one when he has a chance.

In the meantime, however, please consider this issue to be assigned to you.
Others will see that in this comment section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants