add support for new repository invitations #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
force-pushed
the
i-371-repo-invitations
branch
4 times, most recently
from
781b29e to
f26e2d3
Compare
| func (s *RepositoriesService) AddCollaborator(owner, repo, user string, opt *RepositoryAddCollaboratorOptions) (*Response, error) { | ||
| u := fmt.Sprintf("repos/%v/%v/collaborators/%v", owner, repo, user) | ||
| req, err := s.client.NewRequest("PUT", u, opt) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // TODO: remove custom Accept header when this API fully launches. | ||
| req.Header.Set("Accept", mediaTypeRepositoryInvitationsPreview) |
There was a problem hiding this comment.
It's interesting that this takes an existing, previously stable endpoint, and changes it slightly to use the (potentially less stable) preview API. (Usually preview APIs are for new endpoints.)
I think it's fine per our discussion in #376 because people who have really really specific needs will be vendoring this library anyway.
|
I've left 4 inline comments, otherwise LGTM. I did not test the functionality, just reviewed the code. |
gmlewis
force-pushed
the
i-371-repo-invitations
branch
from
f26e2d3 to
6c958ff
Compare
| // ListInvitations lists all currently-open repository invitations for the | ||
| // authenticated user. | ||
| // | ||
| // GitHub API docs: https://developer.github.com/v3/repos/invitations/#list-invitations-for-a-repository |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch! Thanks, @shurcooL
gmlewis
force-pushed
the
i-371-repo-invitations
branch
from
6c958ff to
a4eeb22
Compare
Fixes google#371. Change-Id: I97f2fc28ce048442ee8af3bd11c48b5b2084e09b
gmlewis
force-pushed
the
i-371-repo-invitations
branch
from
a4eeb22 to
5c1b3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371.
Change-Id: I97f2fc28ce048442ee8af3bd11c48b5b2084e09b