Skip to content

feat!: Change User.InheritedFrom to a slice #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

tomfeigin
Copy link
Contributor

@tomfeigin tomfeigin commented Feb 5, 2025

BREAKING CHANGE: User.InheritedFrom is changed from a *Team to a []*Team.

@stevehipwell
Copy link
Contributor

@tomfeigin this looks good to me (I've checked the API directly). I've not managed to use the code yet and it looks like I made a mistake as the schema has this as an array on December 2nd when I opened the original issue.

@gmlewis could you take a look at this please?

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (d392e2c) to head (22c1ed3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3460   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         179      179           
  Lines       15535    15535           
=======================================
  Hits        14142    14142           
  Misses       1221     1221           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). and removed NeedsReview PR is awaiting a review before merging. labels Feb 5, 2025
@gmlewis gmlewis changed the title Change InheritedFrom to a slice feat!: Change User.InheritedFrom to a slice Feb 5, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomfeigin and @stevehipwell!
LGTM.
Merging.

@gmlewis gmlewis merged commit a8a3177 into google:master Feb 5, 2025
7 checks passed
@tomfeigin
Copy link
Contributor Author

@gmlewis thank you :) will you release a new version with the fix?

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 5, 2025

@gmlewis thank you :) will you release a new version with the fix?

This is now available here: https://github.com/google/go-github/releases/tag/v69.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants