Skip to content

Bump version of go-github to v69.0.0 #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Feb 5, 2025

This release contains the following breaking API changes:

  • feat!: Add support for enterprise rulesets #3417
    BREAKING CHANGE: Create*Ruleset and Update*Ruleset now pass ruleset parameter by-value instead of by-reference.
  • fix!: Typo in field names in the CheckSuite struct #3444
    BREAKING CHANGE: Rerequstable=>Rerequestable, RunsRerequstable=>RunsRerequestable
  • fix!: Typo in field names in the PullStats struct #3445
    BREAKING CHANGE: MergablePulls=>MergeablePulls, UnmergablePulls=>UnmergeablePulls
  • refactor!: Do not capitalize error strings #3446
    BREAKING CHANGE: Some error strings are slightly modified - please do not rely on error text in general.
  • fix!: Refactor the repository ruleset code #3430
    BREAKING CHANGES: The following types have been renamed:
    • Ruleset -> RepositoryRuleset
    • RulesetLink -> RepositoryRulesetLink
    • RulesetLinks -> RepositoryRulesetLinks
    • RulesetRefConditionParameters -> RepositoryRulesetRefConditionParameters
    • RulesetRepositoryNamesConditionParameters -> RepositoryRulesetRepositoryNamesConditionParameters
    • RulesetRepositoryIDsConditionParameters -> RepositoryRulesetRepositoryIDsConditionParameters
    • RulesetRepositoryPropertyTargetParameters -> Repository
    • RulesetRepositoryPropertyConditionParameters -> RepositoryRulesetRepositoryPropertyConditionParameters
    • RulesetOrganizationNamesConditionParameters -> RepositoryRulesetOrganizationNamesConditionParameters
    • RulesetOrganizationIDsConditionParameters -> RepositoryRulesetOrganizationIDsConditionParameters
    • RulesetConditions -> RepositoryRulesetConditions
    • RepositoryRulesetEditedChanges -> RepositoryRulesetChanges
    • RepositoryRulesetEditedSource -> RepositoryRulesetChangeSource
    • RepositoryRulesetEditedSources -> RepositoryRulesetChangeSources
    • RepositoryRulesetEditedConditions -> RepositoryRulesetUpdatedConditions
    • RepositoryRulesetUpdatedConditionsEdited -> RepositoryRulesetUpdatedCondition
    • RepositoryRulesetEditedRules -> RepositoryRulesetChangedRules
    • RepositoryRulesetUpdatedRules -> RepositoryRulesetUpdatedRules
    • RepositoryRulesetEditedRuleChanges -> RepositoryRulesetChangedRule
  • chore!: Add sliceofpointers custom linter  #3447
    BREAKING CHANGE: ListOAuthApps now returns ([]*OAuthApp, error) instead of ([]OAuthApp, error).
  • feat!: Change User.InheritedFrom to a slice #3460
    BREAKING CHANGE: User.InheritedFrom is changed from a *Team to a []*Team.

...and the following additional changes:

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (a8a3177) to head (7b8ab91).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3463   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         179      179           
  Lines       15535    15535           
=======================================
  Hits        14142    14142           
  Misses       1221     1221           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis merged commit 59c38a3 into google:master Feb 5, 2025
7 checks passed
@gmlewis gmlewis deleted the release-v69 branch February 5, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant