Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildifier integration no longer reports errors correctly #103

Closed
malcolmr opened this issue Aug 14, 2018 · 0 comments
Closed

buildifier integration no longer reports errors correctly #103

malcolmr opened this issue Aug 14, 2018 · 0 comments
Assignees
@malcolmr
Labels
bug

Comments

@malcolmr
Copy link
Member

The changes for #100 broke the way that buildifier reports errors, because we assume that the filename is called "stdin", and after #101, it's the value of -path:

https://github.com/google/vim-codefmt/blob/4b6cb67/autoload/codefmt/buildifier.vim#L57

This results in e.g.

Error formatting file: ERROR(ShellError): Error running: buildifier -path /home/malcolmr/foo/bar/BUILD
/home/malcolmr/foo/bar/BUILD:112:13: syntax error near cc_library
@malcolmr malcolmr added the bug label Aug 14, 2018
@malcolmr malcolmr self-assigned this Aug 14, 2018
@malcolmr malcolmr mentioned this issue Aug 14, 2018
Open
malcolmr added a commit to malcolmr/vim-codefmt that referenced this issue Aug 14, 2018
@malcolmr
Fix buildifier error reporting.
343cadb 
This was broken by 4b6cb67, which caused error messages to contain the
filename rather than 'stdin'.

Fixes google#103
@malcolmr malcolmr mentioned this issue Aug 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcolmr malcolmr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@malcolmr