Fix buildifier error reporting. #104
Conversation
This was broken by 4b6cb67, which caused error messages to contain the filename rather than 'stdin'. Fixes google#103
| if empty(l:fname) | ||
| let l:fname_pattern = 'stdin' | ||
| else | ||
| let l:fname_pattern = escape(l:fname, '\') |
There was a problem hiding this comment.
Alternatively we could just make the pattern start out something like '\C\v[^:]+:\(\d+)..., and assume that filenames never contained a :, but I suspect that wouldn't work everywhere.
There was a problem hiding this comment.
I could imagine corner cases with the filename being escaped/expanded/canonicalized that with this approach would lead to the error not being matched at all. It might be worth figuring out how to genericize it properly eventually (not a blocker since this does fix the major issue).
There was a problem hiding this comment.
I'm pretty sure that buildifier returns exactly the string we pass to it via -path (after all, it doesn't actually get to read the file content: that's piped to stdin). I'll commit this as-is, and we can always improve it if we need to later.
| if empty(l:fname) | ||
| let l:fname_pattern = 'stdin' | ||
| else | ||
| let l:fname_pattern = escape(l:fname, '\') |
There was a problem hiding this comment.
I could imagine corner cases with the filename being escaped/expanded/canonicalized that with this approach would lead to the error not being matched at all. It might be worth figuring out how to genericize it properly eventually (not a blocker since this does fix the major issue).
This was broken by 4b6cb67, which caused error messages to contain the filename rather than 'stdin'.
Fixes #103