feat: add zprint formatter for clojure #130
Merged
+238
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriffis
force-pushed
the
master
branch
3 times, most recently
from
7520bca to
db75607
Compare
dbarnett
suggested changes
Dec 28, 2019
agriffis
force-pushed
the
master
branch
2 times, most recently
from
6ac19e2 to
95635c9
Compare
|
@dbarnett Thanks for the review. I've squashed the commits and this should be ready to merge unless you have any other concerns. |
|
If you pull #131 before this, then I'll rebase this PR to resolve the minor merge conflict |
|
Rebased to resolve merge conflict with #131 |
dbarnett
reviewed
Jan 6, 2020
zprint unfortunately lacks the ability to format a range, so we implement `:FormatLines` by sending only the lines to be formatted. See kkinnear/zprint#122
|
@dbarnett In case this was lost in code review comments, I updated the tests to use fake I/O fully, and removed the zprint install from travis. Let me know if there's anything else... |
dbarnett
approved these changes
Jan 8, 2020
dbarnett
reviewed
Jan 8, 2020
|
|
||
| "" | ||
| " @section Recommended zprint mappings, mappings-zprint | ||
| " @parentsection mappings |
There was a problem hiding this comment.
Note to self: Build a new vimdoc release. I just found that the @parentsection directive isn't supported yet in the latest vimdoc 0.6.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a formatter for Clojure using zprint.
zprint unfortunately lacks the ability to format a range, so we implement
:FormatLinesby sending only the lines to be formatted. I've opened a PR to add range formatting to zprint, see kkinnear/zprint#122Doc is updated by vimdoc, with a special section
*codefmt-mappings-zprint*suggesting an alternative mapping for top-level forms which depends on also having vim-sexp installed: