Skip to content

refactor: remove unused _count attribute from StreamedResultSet class #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2020
Merged

refactor: remove unused _count attribute from StreamedResultSet class #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4d01bc
refactor: remove unused _count attribute from StreamedResultSet class
Jul 13, 2020
de2825e
Merge branch 'master' into excess_arg
Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions google/cloud/spanner_v1/streamed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class StreamedResultSet(object):
def __init__(self, response_iterator, source=None):
self._response_iterator = response_iterator
self._rows = [] # Fully-processed rows
self._counter = 0 # Counter for processed responses
self._metadata = None # Until set from first PRS
self._stats = None # Until set from last PRS
self._current_row = [] # Accumulated values for incomplete row
Expand Down Expand Up @@ -114,7 +113,6 @@ def _consume_next(self):
Parse the result set into new/existing rows in :attr:`_rows`
"""
response = six.next(self._response_iterator)
self._counter += 1

if self._metadata is None: # first response
metadata = self._metadata = response.metadata
Expand Down