Skip to content

Fix for #644, allow configuration of artifact name for Archive receipt step #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wbonnefond
Copy link

To ensure the Archive receipt step works when run in a matrixed workflow, the artifact name needs to be unique.

This change adds an input to the action for the artifact name archieveReceiptArtifactName and defaults to the previous hardcoded value. This allows callers to specify the name if needed.

In our usecase, we run this in a matrixed workflow against 8 apps, so we can ensure the name is different by appending the app name to the artifact name like:

- name: Run experiment 1
  uses: gradle/gradle-enterprise-build-validation-scripts/.github/actions/gradle/experiment-1@actions-stable
  env:
    DEVELOCITY_ACCESS_KEY: xxxxxx
  with:
    gitRepo: ${{ env.GIT_REPO }}
    gradleEnterpriseUrl: ${{ env.GRADLE_ENTERPRISE_URL }}
    tasks: ${{ env.TASKS }}
    projectDir: ${{ matrix.target.project }}
    archiveReceiptArtifactName: "experiment-1-receipt-${{ matrix.target.project }}"

@wbonnefond
Copy link
Author

Closing as this is being fixed in #648

@wbonnefond wbonnefond closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant