Use unique artifact identifier in upload-artifact step #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprinet
force-pushed
the
jprinet/fix-unique-artifact-id-violation
branch
from
54820bc to
b35a120
Compare
|
This branch fixes the issue I was having in our codebase |
jprinet
force-pushed
the
jprinet/fix-unique-artifact-id-violation
branch
4 times, most recently
from
3356a86 to
560844a
Compare
erichaagdev
reviewed
Aug 6, 2024
| - name: Add artifact link to summary | ||
| run: | | ||
| echo "-------------" >> $GITHUB_STEP_SUMMARY | ||
| echo "Download receipt: [${{ steps.upload-artifact.outputs.artifact-url }}](${{ steps.upload-artifact.outputs.artifact-url }})" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
It's already a link. Is it necessary to wrap it like this?
Suggested change
| echo "Download receipt: [${{ steps.upload-artifact.outputs.artifact-url }}](${{ steps.upload-artifact.outputs.artifact-url }})" >> $GITHUB_STEP_SUMMARY | |
| echo "Download receipt: ${{ steps.upload-artifact.outputs.artifact-url }}" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Good point 😅
I adjusted the PR
jprinet
force-pushed
the
jprinet/fix-unique-artifact-id-violation
branch
from
560844a to
22da139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #644
Since upload-artifact@v4, uploading again the same artifact name in a workflow fails the step.
Using a hardcoded
experiment-X-receiptis not valid anymoreFix
Use a unique name. This is not so straightforward as some collisions can occur in the case of matrix.
Using the
job-indexfor matrix solves this.Note that appending the
job-indexis happening only ifjob-total > 1to not suffix artifacts from non matrix scenarioThis could hopefully get simplified if/when GitHub starts to expose a unique
job-idwhen running with matrix strategy.Extra
A receipt download link has been added as part of the workflow summary
Example
See a summary running with the PR fix here