Fix inability to update managed ML alerts #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
csmarchbanks
force-pushed
the
ml-alerts-fix-updating
branch
from
3d031bd to
a455c0f
Compare
The ID field was not being populated by the plan so we were attempting to create a new alert instead of updating the existing alert. Adding the UseStateForUnknown plan modifier fixes this.
csmarchbanks
force-pushed
the
ml-alerts-fix-updating
branch
from
a455c0f to
f7a66d4
Compare
julienduchesne
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ID field was not being populated by the plan so we were attempting
to create a new alert instead of updating the existing alert. Adding the
UseStateForUnknown plan modifier fixes this.
Fixes: #1681