-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix videos for conf 2024 #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix videos for conf 2024 #1819
Conversation
@dimaMachina is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
<div className="flex flex-col lg:px-0"> | ||
<BackLink year="2024" kind="schedule" /> | ||
|
||
{recordingTitle.rating > 0.5 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk what was the reason to show video based on rating, so I removed this, cc @saihaj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. mentioned video in PR was not shown due to rating 0.464
{
"target": "Comparing API Protocols - One Feature at a Time - Uri Goldshtein, The Guild",
"rating": 0.4642857142857143
}
if (!videoId) { | ||
throw new Error(`Video "${recordingTitle.target}" not found`) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a check to throw an error on build time if video is missing
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e.g. https://graphql.org/conf/2024/schedule/0cc847db0ed6bf193da7b5413c7f3e8e/?name=Sponsored%20Keynote%3A%20Uri%20Goldshtein%2C%20The%20Guild here video is missing