Skip to content

fix videos for conf 2024 #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

dimaMachina
Copy link
Contributor

Copy link

vercel bot commented Nov 6, 2024

@dimaMachina is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

<div className="flex flex-col lg:px-0">
<BackLink year="2024" kind="schedule" />

{recordingTitle.rating > 0.5 && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk what was the reason to show video based on rating, so I removed this, cc @saihaj

Copy link
Contributor Author

@dimaMachina dimaMachina Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. mentioned video in PR was not shown due to rating 0.464

{
  "target": "Comparing API Protocols - One Feature at a Time - Uri Goldshtein, The Guild",
  "rating": 0.4642857142857143
}

Comment on lines +105 to +107
if (!videoId) {
throw new Error(`Video "${recordingTitle.target}" not found`)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a check to throw an error on build time if video is missing

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 3:09pm

@Urigo Urigo merged commit 53f4f75 into graphql:source Nov 11, 2024
4 checks passed
mandiwise pushed a commit to mandiwise/graphql.github.io that referenced this pull request Nov 19, 2024
mandiwise pushed a commit to mandiwise/graphql.github.io that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants