fix videos for conf 2024 #1819
Merged
fix videos for conf 2024 #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimaMachina is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
dimaMachina
commented
Nov 6, 2024
| <div className="flex flex-col lg:px-0"> | ||
| <BackLink year="2024" kind="schedule" /> | ||
|
|
||
| {recordingTitle.rating > 0.5 && ( |
There was a problem hiding this comment.
idk what was the reason to show video based on rating, so I removed this, cc @saihaj
There was a problem hiding this comment.
e.g. mentioned video in PR was not shown due to rating 0.464
{
"target": "Comparing API Protocols - One Feature at a Time - Uri Goldshtein, The Guild",
"rating": 0.4642857142857143
}
dimaMachina
commented
Nov 6, 2024
Comment on lines
+105
to
+107
| if (!videoId) { | ||
| throw new Error(`Video "${recordingTitle.target}" not found`) | ||
| } |
There was a problem hiding this comment.
I also added a check to throw an error on build time if video is missing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandiwise
pushed a commit
to mandiwise/graphql.github.io
that referenced
this pull request
Nov 19, 2024
mandiwise
pushed a commit
to mandiwise/graphql.github.io
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. https://graphql.org/conf/2024/schedule/0cc847db0ed6bf193da7b5413c7f3e8e/?name=Sponsored%20Keynote%3A%20Uri%20Goldshtein%2C%20The%20Guild here video is missing