-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix videos for conf 2024 #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix videos for conf 2024 #1819
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-100 Bytes
public/nextImageExportOptimizer/sf-city-view.d5d36dff-opt-10.WEBP
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-130 Bytes
public/nextImageExportOptimizer/sf-city-view.d5d36dff-opt-16.WEBP
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-314 Bytes
public/nextImageExportOptimizer/sf-city-view.d5d36dff-opt-32.WEBP
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-486 Bytes
public/nextImageExportOptimizer/sf-city-view.d5d36dff-opt-48.WEBP
Binary file not shown.
Binary file removed
BIN
-782 Bytes
public/nextImageExportOptimizer/sf-city-view.d5d36dff-opt-64.WEBP
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ const Tag = ({ | |
<span | ||
className={clsx( | ||
"border border-solid border-[#333333] font-semibold text-sm px-3 py-1 h-max rounded-full whitespace-nowrap", | ||
featured ? "bg-[#F8779D] border-[#F8779D] border-2 text-white" : "", | ||
featured && "bg-[#F8779D] border-[#F8779D] border-2 text-white", | ||
)} | ||
> | ||
{text} | ||
|
@@ -100,111 +100,106 @@ export default function SessionPage({ params }: SessionProps) { | |
videos.map(e => e.title), | ||
).bestMatch | ||
|
||
const videoId = videos.find(e => e.title === recordingTitle.target)?.id | ||
|
||
if (!videoId) { | ||
throw new Error(`Video "${recordingTitle.target}" not found`) | ||
} | ||
|
||
return ( | ||
<div className="bg-[#f4f6f8]"> | ||
<div className="container"> | ||
<div className="py-10"> | ||
<section className="text-[#333333] min-h-[80vh] flex-col mx-auto px-2 xs:px-0 lg:justify-between justify-center md:container"> | ||
<div className="flex flex-col lg:px-0"> | ||
<BackLink year="2024" kind="schedule" /> | ||
|
||
{recordingTitle.rating > 0.5 && ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. idk what was the reason to show video based on rating, so I removed this, cc @saihaj There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. e.g. mentioned video in PR was not shown due to rating 0.464 {
"target": "Comparing API Protocols - One Feature at a Time - Uri Goldshtein, The Guild",
"rating": 0.4642857142857143
} |
||
<iframe | ||
className="aspect-video max-w-[1000px] mx-auto size-full rounded-md" | ||
src={`https://youtube.com/embed/${ | ||
videos.find(e => e.title === recordingTitle.target)?.id | ||
}`} | ||
title={recordingTitle.target} | ||
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" | ||
allowFullScreen | ||
/> | ||
)} | ||
|
||
<div className="mt-10 flex flex-col self-center prose lg:prose-lg sm:space-y-4"> | ||
<div className="space-y-5"> | ||
<div className="flex gap-3 flex-wrap"> | ||
<Tag text={eventType} featured /> | ||
<Tag text={event.audience} /> | ||
<Tag text={event.event_subtype} /> | ||
</div> | ||
<h1 className="mt-0 text-2xl lg:text-3xl font-medium"> | ||
{eventTitle} | ||
</h1> | ||
<span className="text-[#333333]"> | ||
{format( | ||
parseISO(event.event_start), | ||
"EEEE, MMMM d / hh:mmaaaa 'PDT'", | ||
)}{" "} | ||
- {format(parseISO(event.event_end), "hh:mmaaaa 'PDT'")} | ||
</span> | ||
</div> | ||
<div className="flex flex-wrap lg:flex-row flex-col gap-5 mt-8"> | ||
{event.speakers!.map(speaker => ( | ||
<div | ||
className={`flex items-center gap-3 w-full ${event?.speakers?.length || 0 > 1 ? "max-w-[320px]" : ""}`} | ||
key={speaker.username} | ||
> | ||
<Avatar | ||
className="lg:size-[120px] size-[100px] rounded-full" | ||
avatar={speaker.avatar} | ||
name={speaker.name} | ||
/> | ||
|
||
<div className="flex flex-col lg:gap-1 gap-1.5"> | ||
<a | ||
href={`/conf/2024/speakers/${speaker.username}`} | ||
className="text-xl mt-0 font-bold text-[#333333] underline" | ||
> | ||
{speaker.name} | ||
</a> | ||
|
||
<span className="font-normal"> | ||
<span className="font-semibold"> | ||
{speaker.company} | ||
</span> | ||
{speaker.company && ", "} | ||
{speaker.position} | ||
</span> | ||
{speaker.socialurls?.length ? ( | ||
<div className="mt-0 text-[#333333]"> | ||
<div className="flex space-x-2"> | ||
{speaker.socialurls.map(social => ( | ||
<a | ||
key={social.url} | ||
href={social.url} | ||
target="_blank" | ||
rel="noreferrer" | ||
className="flex items-center text-black" | ||
> | ||
<SocialMediaIcon | ||
service={ | ||
social.service.toLowerCase() as SocialMediaIconServiceType | ||
} | ||
/> | ||
</a> | ||
))} | ||
</div> | ||
</div> | ||
) : null} | ||
</div> | ||
</div> | ||
))} | ||
<BackLink year="2024" kind="schedule" /> | ||
<iframe | ||
className="aspect-video w-full max-w-4xl mx-auto rounded-md mt-6" | ||
src={`https://youtube.com/embed/${videoId}`} | ||
title={recordingTitle.target} | ||
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" | ||
allowFullScreen | ||
/> | ||
|
||
<div className="mt-10 flex flex-col self-center prose lg:prose-lg sm:space-y-4 mx-auto"> | ||
<div className="space-y-5"> | ||
<div className="flex gap-3 flex-wrap"> | ||
<Tag text={eventType} featured /> | ||
<Tag text={event.audience} /> | ||
<Tag text={event.event_subtype} /> | ||
</div> | ||
<p>{event.description}</p> | ||
|
||
<div className="py-8"> | ||
{event.files?.map(({ path }) => ( | ||
<div key={path}> | ||
<a href={path} target="_blank" rel="noreferrer"> | ||
View Full PDF{" "} | ||
<span className="font-sans font-light text-2xl"> | ||
↗ | ||
</span> | ||
<h1 className="mt-0 text-2xl lg:text-3xl font-medium"> | ||
{eventTitle} | ||
</h1> | ||
<span className="text-[#333333]"> | ||
{format( | ||
parseISO(event.event_start), | ||
"EEEE, MMMM d / hh:mmaaaa 'PDT'", | ||
)}{" "} | ||
- {format(parseISO(event.event_end), "hh:mmaaaa 'PDT'")} | ||
</span> | ||
</div> | ||
<div className="flex flex-wrap lg:flex-row flex-col gap-5 mt-8"> | ||
{event.speakers!.map(speaker => ( | ||
<div | ||
className={`flex items-center gap-3 w-full ${event?.speakers?.length || 0 > 1 ? "max-w-[320px]" : ""}`} | ||
key={speaker.username} | ||
> | ||
<Avatar | ||
className="lg:size-[120px] size-[100px] rounded-full" | ||
avatar={speaker.avatar} | ||
name={speaker.name} | ||
/> | ||
|
||
<div className="flex flex-col lg:gap-1 gap-1.5"> | ||
<a | ||
href={`/conf/2024/speakers/${speaker.username}`} | ||
className="text-xl mt-0 font-bold text-[#333333] underline" | ||
> | ||
{speaker.name} | ||
</a> | ||
<iframe src={path} className="aspect-video size-full" /> | ||
|
||
<span className="font-normal"> | ||
<span className="font-semibold">{speaker.company}</span> | ||
{speaker.company && ", "} | ||
{speaker.position} | ||
</span> | ||
{speaker.socialurls?.length ? ( | ||
<div className="mt-0 text-[#333333]"> | ||
<div className="flex space-x-2"> | ||
{speaker.socialurls.map(social => ( | ||
<a | ||
key={social.url} | ||
href={social.url} | ||
target="_blank" | ||
rel="noreferrer" | ||
className="flex items-center text-black" | ||
> | ||
<SocialMediaIcon | ||
service={ | ||
social.service.toLowerCase() as SocialMediaIconServiceType | ||
} | ||
/> | ||
</a> | ||
))} | ||
</div> | ||
</div> | ||
) : null} | ||
</div> | ||
))} | ||
</div> | ||
</div> | ||
))} | ||
</div> | ||
<p>{event.description}</p> | ||
|
||
<div className="py-8"> | ||
{event.files?.map(({ path }) => ( | ||
<div key={path}> | ||
<a href={path} target="_blank" rel="noreferrer"> | ||
View Full PDF{" "} | ||
<span className="font-sans font-light text-2xl">↗</span> | ||
</a> | ||
<iframe src={path} className="aspect-video size-full" /> | ||
</div> | ||
))} | ||
</div> | ||
</div> | ||
</section> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a check to throw an error on build time if video is missing