Skip to content

Add command for emoji name lookup #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hackebrot opened this issue Sep 30, 2019 · 0 comments · Fixed by #15
Closed

Add command for emoji name lookup #8

hackebrot opened this issue Sep 30, 2019 · 0 comments · Fixed by #15
Labels
enhancement New feature or enhancement for turtle good first issue Tasks for new contributors to turtle
Milestone
0.2.0

Comments

@hackebrot
Copy link
Owner

This command would accept a emoji symbol and print the name of that emoji

turtle name 🤖
> robot
@hackebrot hackebrot added enhancement New feature or enhancement for turtle help wanted labels Sep 30, 2019
Scuilion added a commit to Scuilion/turtle that referenced this issue Oct 7, 2019
@Scuilion
add name command closes hackebrot#8
dcb2ab7
@hackebrot hackebrot added good first issue Tasks for new contributors to turtle and removed help wanted labels Nov 14, 2019
hackebrot pushed a commit that referenced this issue May 16, 2020
@Scuilion @hackebrot
add name command closes #8
56d8bcb
hackebrot added a commit that referenced this issue May 16, 2020
@hackebrot
Revert "add name command closes #8"
ffce8a0 
The commit helped me realize that it makes more sense for the library to
feature an additional map from emoji character to emoji rather than a
new function which outputs a single struct field.

This reverts commit 56d8bcb.
@hackebrot hackebrot mentioned this issue May 16, 2020
Merged
@hackebrot hackebrot added this to the 0.2.0 milestone May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or enhancement for turtle good first issue Tasks for new contributors to turtle
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Add lookup by emoji character 🕵️‍♂️ hackebrot/turtle
1 participant
@hackebrot