Add lookup by emoji character 🕵️♂️ #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve @Scuilion's commit in the git history as it was decisive for the revised design featuring a new map by emoji character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new map to the library
EmojisByCharand a new commandcharto look up an emoji by its character.Thanks so much @Scuilion for #9 as it helped me realize that it makes more sense for the library to feature an additional map from emoji character to emoji rather than a new function which outputs a single struct field. I think this revised design is more consistent and intuitive. I'm sorry that it's taken me so long to review your changes. I cherry-picked and reverted your commit to make sure your contribution is reflected in the GitHub contributors view. 🐢
Resolve #8