Skip to content

Turn the CI green before the next release #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixdivo opened this issue Jan 26, 2022 · 2 comments
Closed

Turn the CI green before the next release #1230

felixdivo opened this issue Jan 26, 2022 · 2 comments
Assignees
Labels
blocker minor QA about improving and maintaining the quality of the library
Milestone

Comments

@felixdivo
Copy link
Collaborator

Most of the work was done in #1224 and #1221, but maybe small stuff is left and we want to have a clean release.

@felixdivo felixdivo added minor blocker QA about improving and maintaining the quality of the library labels Jan 26, 2022
@felixdivo felixdivo added this to the 4.0.0 Release milestone Jan 26, 2022
@felixdivo felixdivo self-assigned this Jan 26, 2022
@zariiii9003
Copy link
Collaborator

There are also some deprecation warnings that we could fix

can/interfaces/__init__.py:36
  /home/runner/work/python-can/python-can/can/interfaces/__init__.py:36: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
    if "can.interface" in entry:

test/notifier_test.py::AsyncNotifierTest::test_asyncio_notifier
  /home/runner/work/python-can/python-can/test/notifier_test.py:43: DeprecationWarning: There is no current event loop
    loop = asyncio.get_event_loop()

@felixdivo
Copy link
Collaborator Author

Since c7ba84a, this should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker minor QA about improving and maintaining the quality of the library
Projects
None yet
Development

No branches or pull requests

2 participants