Fix entry_points deprecation #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdivo
added
the
QA
Codecov Report
@@ Coverage Diff @@
## develop #1233 +/- ##
===========================================
+ Coverage 65.88% 65.90% +0.01%
===========================================
Files 86 86
Lines 8884 8886 +2
===========================================
+ Hits 5853 5856 +3
+ Misses 3031 3030 -1 |
zariiii9003
approved these changes
Jan 27, 2022
zariiii9003
reviewed
Jan 27, 2022
|
|
||
| BACKENDS.update( | ||
| {interface.name: tuple(interface.value.split(":")) for interface in entries} | ||
| ) | ||
| except ImportError: | ||
| from pkg_resources import iter_entry_points |
There was a problem hiding this comment.
Do we still need this?
There was a problem hiding this comment.
Probably not for long, see #1234. 😃
zariiii9003
reviewed
Jan 27, 2022
| entries = entry_points(group="can.interface") | ||
| except TypeError: | ||
| # Fallback for Python <3.10 | ||
| # See https://docs.python.org/3/library/importlib.metadata.html#entry-points, "Compatibility Note" |
There was a problem hiding this comment.
We could also use importlib_metadata from PyPI as fallback
There was a problem hiding this comment.
That would also be possible, yep.
As it's just so little effort, I thought it's simpler to just handle the fallback here.
|
This PR should also be squashed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1230.