Skip to content

Move Static Code Analysis to Github Actions #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

zariiii9003
Copy link
Collaborator

Move mypy and pylint to github.

See #1219.

There's still some issues with GzipASCWriter and mypy that i won't fix because of #1221

@zariiii9003 zariiii9003 added the QA about improving and maintaining the quality of the library label Jan 20, 2022
@zariiii9003 zariiii9003 added this to the 4.0.0 Release milestone Jan 20, 2022
@zariiii9003 zariiii9003 requested a review from felixdivo January 20, 2022 15:51
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1224 (b75e214) into develop (803a712) will increase coverage by 0.03%.
The diff coverage is 96.42%.

@@             Coverage Diff             @@
##           develop    #1224      +/-   ##
===========================================
+ Coverage    65.83%   65.87%   +0.03%     
===========================================
  Files           86       86              
  Lines         8860     8872      +12     
===========================================
+ Hits          5833     5844      +11     
- Misses        3027     3028       +1     

Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Great cleanups :)

pip install -r requirements-lint.txt
- name: mypy 3.7
run: |
mypy --python-version 3.7 .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to test all of the version!

@zariiii9003 zariiii9003 merged commit 94c1701 into hardbyte:develop Jan 21, 2022
@zariiii9003 zariiii9003 deleted the move_mypy branch January 21, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA about improving and maintaining the quality of the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants