Skip to content

Modernize all the test cases #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2019
Merged

Modernize all the test cases #596

merged 5 commits into from
May 19, 2019

Conversation

felixdivo
Copy link
Collaborator

This modernizes all python files in test/. I basically ran 2to3 on it and the went over them by hand to correct or add some changes manually.

@felixdivo
Copy link
Collaborator Author

This requires #594 to be merged first.

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@544f6c3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #596   +/-   ##
==========================================
  Coverage           ?   64.05%           
==========================================
  Files              ?       63           
  Lines              ?     5722           
  Branches           ?        0           
==========================================
  Hits               ?     3665           
  Misses             ?     2057           
  Partials           ?        0

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #596 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #596   +/-   ##
========================================
  Coverage    59.97%   59.97%           
========================================
  Files           63       63           
  Lines         5572     5572           
========================================
  Hits          3342     3342           
  Misses        2230     2230

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so very satisfying.

@@ -5,8 +5,6 @@
This module tests two virtual buses attached to each other.
"""

from __future__ import absolute_import, print_function
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 we are in the future.

@felixdivo felixdivo merged commit 0073548 into develop May 19, 2019
@felixdivo felixdivo deleted the modernze-tests branch May 19, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants