Remove support for old Python versions #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A nice side effect is the CI being a lot faster. ^^ |
|
I have a question (@christiansandberg) regarding socketcan: try:
socket.CAN_BCM
except AttributeError:
HAS_NATIVE_SUPPORT = False
else:
HAS_NATIVE_SUPPORT = TrueCan this be removed, since it will evaluate to |
Codecov Report
@@ Coverage Diff @@
## develop #594 +/- ##
==========================================
- Coverage 64.18% 63.98% -0.2%
==========================================
Files 63 63
Lines 5685 5573 -112
==========================================
- Hits 3649 3566 -83
+ Misses 2036 2007 -29 |
|
You can assume that native support is always available. |
|
I'll open two more separate PRs: One for removing deprecated members and one for changing the calls to super() to the Python 3 syntax. |
This was referenced May 18, 2019
|
I tried to split the conversion in multiple parts but this one is the first and biggest one. The others are simpler. This PR is now done (apart from the reviews coming in 😅). @christiansandberg The socketcan change was applied as well. |
christiansandberg
approved these changes
May 18, 2019
felixdivo
force-pushed
the
remove-old-python-versions
branch
from
3693e5e to
174ff81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for Python < 3.6, both CPython and PyPy in the codebase and CI pipelines.