Skip to content

Use the Python 3 super() syntax #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2019
Merged

Use the Python 3 super() syntax #597

merged 5 commits into from
May 19, 2019

Conversation

felixdivo
Copy link
Collaborator

Updates the code in can/** & test/**.

This can only be merged once #594 got merged.

@felixdivo felixdivo added this to the 4.0 Release milestone May 18, 2019
@felixdivo felixdivo self-assigned this May 18, 2019
@felixdivo felixdivo changed the title Use the python 3 super() syntax Use the Python 3 super() syntax May 18, 2019
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@544f6c3). Click here to learn what that means.
The diff coverage is 58.06%.

@@            Coverage Diff             @@
##             develop     #597   +/-   ##
==========================================
  Coverage           ?   64.18%           
==========================================
  Files              ?       63           
  Lines              ?     5721           
  Branches           ?        0           
==========================================
  Hits               ?     3672           
  Misses             ?     2049           
  Partials           ?        0

@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #597 into develop will increase coverage by 0.01%.
The diff coverage is 58.06%.

@@             Coverage Diff             @@
##           develop     #597      +/-   ##
===========================================
+ Coverage    63.98%   63.99%   +0.01%     
===========================================
  Files           63       63              
  Lines         5573     5572       -1     
===========================================
  Hits          3566     3566              
+ Misses        2007     2006       -1

Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

@felixdivo felixdivo merged commit c3a87fd into develop May 19, 2019
@felixdivo felixdivo deleted the use-new-super-syntax branch May 19, 2019 12:10
@felixdivo
Copy link
Collaborator Author

@hardbyte Appveyor has problems and does not execute thests any more. See the last commit on this PR: it does not have the Appveyor entry in the test/CI list. This could be a clue: https://ci.appveyor.com/project/hardbyte/python-can/builds/24650559

@felixdivo
Copy link
Collaborator Author

It seems to be working again here: https://ci.appveyor.com/project/hardbyte/python-can/builds/24651358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants