Skip to content

FFM-11660 Add configurable limit to the seen targets map #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 9, 2024
Merged

FFM-11660 Add configurable limit to the seen targets map #165

merged 8 commits into from
Sep 9, 2024

Conversation

erdirowlands
Copy link
Contributor

@erdirowlands erdirowlands commented Sep 6, 2024 •
edited
Loading

What

  • Adds a configurable limit, defaulting to 500k targets, to seenTargets.
  • Adds a configurable clearing schedule, defaulting to 24 hours, to seenTargets
  • Change bucketBy missing attribute log from warn to debug

Why

To provide a sensible default upper bound for this map.

Testing

  • New unit tests for size and clearing behaviour
  • Manual smoke test

@erdirowlands
FFM-11660 Add size and clearing interval to safe seen targets
4f4a14a 
FFM-11660 Update tests

FFM-11660 Make seen targets max size and clearing schedule configurable with defaults

FFM-11660 Change level of bucketby missing log to debug

FFM-11660 Add size and clearing interval to safe seen targets
@erdirowlands
FFM-11660 Test for safe maps
35422d5
@erdirowlands
FFM-11660 Logic tweak
28b5889
@erdirowlands
FFM-11660 Move seen targets clear interval to analytics
0e189da 
FFM-11660 Add comment

FFM-11660 Add Bump version

FFM-11660 Add a stop clearing method
@erdirowlands
FFM-11660 Change info log to debug log
368d978
@erdirowlands
FFM-11660 Fix tests
751afa3
@erdirowlands
FFM-11660 Use set instead of set with limit
8eff45c
@erdirowlands erdirowlands merged commit a9511ed into main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcox250 jcox250 jcox250 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdirowlands @jcox250