FFM-9097 Don't set global Axios timeout #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f055da3.
erdirowlands
commented
May 2, 2024
| @@ -1 +1 @@ | |||
| export const VERSION = '1.7.0'; | |||
| export const VERSION = '1.8.0'; | |||
There was a problem hiding this comment.
The version was bumped to 1.8.0 in the last PR and has not been released yet. We forgot to update the version here in that PR.
Therefore I haven't also bumped the minor version in this PR in package.json
andybharness
approved these changes
May 2, 2024
renovate bot
referenced
this pull request
in open-feature/playground
Jul 27, 2024
#331) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@harnessio/ff-nodejs-server-sdk](https://docs.harness.io/category/vjolt35atg-feature-flags) ([source](https://togithub.com/harness/ff-nodejs-server-sdk)) | [`1.7.0` -> `1.8.2`](https://renovatebot.com/diffs/npm/@harnessio%2fff-nodejs-server-sdk/1.7.0/1.8.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>harness/ff-nodejs-server-sdk (@​harnessio/ff-nodejs-server-sdk)</summary> ### [`v1.8.2`](https://togithub.com/harness/ff-nodejs-server-sdk/releases/tag/1.8.2) [Compare Source](https://togithub.com/harness/ff-nodejs-server-sdk/compare/1.8.1...1.8.2) #### What's Changed - FFM-11656 Sort AND/OR rules when caching group instead of during an evaluation call, which could result in latency if a group is large by [@​erdirowlands](https://togithub.com/erdirowlands) in [https://github.com/harness/ff-nodejs-server-sdk/pull/117](https://togithub.com/harness/ff-nodejs-server-sdk/pull/117) **Full Changelog**: harness/ff-nodejs-server-sdk@1.8.1...1.8.2 ### [`v1.8.1`](https://togithub.com/harness/ff-nodejs-server-sdk/releases/tag/1.8.1) [Compare Source](https://togithub.com/harness/ff-nodejs-server-sdk/compare/1.8.0...1.8.1) #### What's Changed - FFM-11673 Patch braces CVE by [@​erdirowlands](https://togithub.com/erdirowlands) in [https://github.com/harness/ff-nodejs-server-sdk/pull/116](https://togithub.com/harness/ff-nodejs-server-sdk/pull/116) **Full Changelog**: harness/ff-nodejs-server-sdk@1.8.0...1.8.1 ### [`v1.8.0`](https://togithub.com/harness/ff-nodejs-server-sdk/releases/tag/1.8.0) [Compare Source](https://togithub.com/harness/ff-nodejs-server-sdk/compare/1.7.0...1.8.0) #### What's Changes - FFM-9097 Global Axios settings are no longer configured by the SDK, which could override Axios settings used elsewhere in an application. The default timeout is 30s but can be changed using options using `axiosTimeout`, see: [Options](https://togithub.com/harness/ff-nodejs-server-sdk/blob/main/docs/further_reading.md#available-options) by [@​erdirowlands](https://togithub.com/erdirowlands) in [https://github.com/harness/ff-nodejs-server-sdk/pull/114](https://togithub.com/harness/ff-nodejs-server-sdk/pull/114) - \[FFM-11243] - Adding SDK support for AND/OR rules (feature not GA yet) by [@​andybharness](https://togithub.com/andybharness) in [https://github.com/harness/ff-nodejs-server-sdk/pull/113](https://togithub.com/harness/ff-nodejs-server-sdk/pull/113) - FFM-11364 Use target-segments v2-rule parameter by [@​erdirowlands](https://togithub.com/erdirowlands) in [https://github.com/harness/ff-nodejs-server-sdk/pull/115](https://togithub.com/harness/ff-nodejs-server-sdk/pull/115) **Full Changelog**: harness/ff-nodejs-server-sdk@1.7.0...1.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/playground). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Options. The timeout will default to30000msif not set.Testing
Timeout configuration:
Timeout not set by user defaults
30000ms:Timeout set to
40000msRequests: