-
Notifications
You must be signed in to change notification settings - Fork 8
FFM-9097 Don't set global Axios timeout #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
330ccd1
FFM-9097 Create custom axios instance instead of using global config
erdirowlands f66233a
FFM-9097 Allow axios timeout to be configurable
erdirowlands f055da3
FFM-9097 Bump minor version for release
erdirowlands cee48b8
FFM-9097 Docs update for axios timeout
erdirowlands caf28ad
FFM-9097 Rename axios instance method
erdirowlands 3bd7055
FFM-9097 Prettier
erdirowlands 69c9b38
Revert "FFM-9097 Bump minor version for release"
erdirowlands a4daa3b
FFM-9097 Version was not updated
erdirowlands 8438a69
FFM-9097 Explicit type
erdirowlands bbe12f4
FFM-9097 Improve comment
erdirowlands 6652af1
FFM-9097 Remove globals
erdirowlands 577f83c
FFM-9097 Fix default timeout
erdirowlands 14e10eb
FFM-9097 Fix default timeout
erdirowlands 38160e9
FFM-9097 Fix custom http client not working with metrics
erdirowlands File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
export const VERSION = '1.7.0'; | ||
export const VERSION = '1.8.0'; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version was bumped to
1.8.0
in the last PR and has not been released yet. We forgot to update the version here in that PR.Therefore I haven't also bumped the minor version in this PR in package.json