Skip to content

FFM-4331 - Change evaluation logic for Target Groups #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

stephenmcconkey
Copy link
Contributor

@stephenmcconkey stephenmcconkey commented Aug 18, 2022

What
Changes evaluation logic for target groups, so that the logic works as OR's rather than AND's... I.e. only one of the conditions must be true

Why
FFM-4331
FFM-4219

@stephenmcconkey stephenmcconkey changed the title FFM-4331 - Change evaluation logic, so that targetgroup rules are treated as OR'… FFM-4331 - Change evaluation logic for Target Groups Aug 18, 2022
@stephenmcconkey stephenmcconkey marked this pull request as ready for review August 18, 2022 10:38
Copy link
Contributor

@enver-bisevac enver-bisevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenmcconkey stephenmcconkey merged commit d7a9a12 into main Aug 22, 2022
@knagurski knagurski deleted the FFM-4331 branch July 13, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants