Skip to content

FFM-4331 - Change evaluation logic for Target Groups #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022
Merged

FFM-4331 - Change evaluation logic for Target Groups #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/evaluator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,13 @@ export class Evaluator {
target: Target,
): Promise<boolean> {
for (const clause of clauses) {
if (!(await this.evaluateClause(clause, target))) {
// some clause condition not met return false
return false;
if ((await this.evaluateClause(clause, target))) {
// If any clause returns true we return - rules being treated as OR rather than AND
return true;
}
}
// all clauses conditions passed so return true
return true;
// all clauses conditions failed so return false
return false;
}

private evaluateRule(rule: ServingRule, target: Target): Promise<boolean> {
Expand Down
2 changes: 1 addition & 1 deletion src/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const VERSION = "1.2.6";
export const VERSION = "1.2.7";