-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/add-methods-consuming-collection #290
Improvement/add-methods-consuming-collection #290
Conversation
Related to #170 |
5b7d49c
to
74bfb24
Compare
Nice PR 👍
List<String> topicFilters = Arrays.asList("test", "hello", "world");
MqttQos qos = MqttQos.EXACTLY_ONCE;
Mqtt5Subscribe.builder()
.addSubscriptions(topicFilters.stream().map(topicFilter ->
Mqtt5Subscription.builder().topicFilter(topicFilter).qos(qos).build()))
.build(); This would also allow us to only take List<String> topicFilters = Arrays.asList("test", "hello", "world");
Mqtt5Unsubscribe.builder().addTopicFilters(topicFilters.stream().map(MqttTopicFilter::of)).build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above
39354a7
to
54aeb1d
Compare
I removed the label and milestone as we have a ticket for tracking this data: #170 |
5fa8024
to
819edf4
Compare
819edf4
to
845f1f9
Compare
Motivation
It should be easy to add a dynamic amount of topics to a Subscribe/Unsubscribe packet or User Properties to any packet.
Resolves #170
Changes
Added methods that consume collection for: