RDM-4369: Support reserved characters in userId email address #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `GET` request to `/user-profile/users` endpoint uses a fully encoded URL, to allow reserved characters in the `uid` query parameter.
Switch to using `DefaultUriBuilderFactory` in Spring Boot 2 to encode the request URL, to fix a problem with "double encoding" of query parameters (see spring-projects/spring-framework#20750 (comment)).
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 95.28% 95.35% +0.07%
==========================================
Files 295 295
Lines 6676 6672 -4
Branches 389 387 -2
==========================================
+ Hits 6361 6362 +1
+ Misses 315 310 -5
Continue to review full report at Codecov.
|
gbenadikar
suggested changes
Mar 19, 2019
src/main/java/uk/gov/hmcts/ccd/data/user/DefaultUserRepository.java
Outdated
Show resolved
Hide resolved
…tring parameter Avoid setting the encoding mode on `restTemplate` because this is an autowired singleton bean, shared across the application. A future ticket will address encoding query string parameters for *all* requests, using `restTemplate`.
gbenadikar
reviewed
Mar 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 95.28% 95.35% +0.07%
==========================================
Files 295 295
Lines 6676 6681 +5
Branches 389 389
==========================================
+ Hits 6361 6371 +10
+ Misses 315 310 -5
Continue to review full report at Codecov.
|
mohammedanas
added a commit
that referenced
this pull request
Apr 30, 2019
* master: RDM-4542: Use lowercase email for User Profile retrieval (#452) FR-901 Revert "RDM-3325: White space validation rules applied on text fields (#284)" (#459) RDM-4610: CVE-2019-0232 fix (#458) increased default callback timeout from 15sec to 60 sec Rdm 3897- Retrieve all the case data (#376) RDM-3325: White space validation rules applied on text fields (#284) RDM-4369: Support reserved characters in userId email address (#420) Add externalId index for CMC (#418) Fix OWASP issue (#456) SIDAM Switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RDM-4369.
Change description
Ensure
GETrequest to/user-profile/usersendpoint uses a fully encoded URL, to allow reserved characters in theuidquery parameter.Does this PR introduce a breaking change? (check one with "x")
Note: PR hmcts/ccd-user-profile-api#173 must be merged to
masterbefore this change; User Profile API needs to be able to decode the encoded email address passed in theuidquery parameter, as a result of this PR.