Skip to content

Revert "RDM-3325: White space validation rules applied on text fields" #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2019
Merged

Revert "RDM-3325: White space validation rules applied on text fields" #459

merged 2 commits into from
Apr 18, 2019

Conversation

hemantt
Copy link
Contributor

@hemantt hemantt commented Apr 18, 2019

Reverts #284

@hemantt hemantt requested a review from mario-paniccia April 18, 2019 11:35
mario-paniccia
mario-paniccia approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@mario-paniccia mario-paniccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #459 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.02%     
==========================================
  Files         296      295       -1     
  Lines        6701     6692       -9     
  Branches      392      390       -2     
==========================================
- Hits         6389     6382       -7     
+ Misses        312      310       -2
Impacted Files Coverage Δ
...v/hmcts/ccd/domain/model/definition/FieldType.java 97.56% <ø> (ø) ⬆️
.../gov/hmcts/ccd/domain/types/BaseTypeValidator.java 100% <100%> (ø) ⬆️
...a/uk/gov/hmcts/ccd/domain/types/TextValidator.java 100% <100%> (ø) ⬆️
...cd/domain/types/sanitiser/CollectionSanitiser.java 100% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2030106...13579c9. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 18, 2019 12:12 Inactive
@hemantt hemantt merged commit 67b6af4 into master Apr 18, 2019
@hemantt hemantt deleted the revert-284-RDM-3325 branch April 18, 2019 13:46
@noronhaa noronhaa restored the revert-284-RDM-3325 branch April 18, 2019 13:59
mohammedanas added a commit that referenced this pull request Apr 30, 2019
@mohammedanas
Merge branch 'master' into RDM-4374
8fceb19 
* master:
  RDM-4542: Use lowercase email for User Profile retrieval (#452)
  FR-901
  Revert "RDM-3325: White space validation rules applied on text fields (#284)" (#459)
  RDM-4610: CVE-2019-0232 fix (#458)
  increased default callback timeout from 15sec to 60 sec
  Rdm 3897- Retrieve all the case data (#376)
  RDM-3325: White space validation rules applied on text fields (#284)
  RDM-4369: Support reserved characters in userId email address (#420)
  Add externalId index for CMC (#418)
  Fix OWASP issue (#456)
  SIDAM Switch
@timja timja deleted the revert-284-RDM-3325 branch September 23, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngul ngul ngul approved these changes

@mario-paniccia mario-paniccia mario-paniccia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hemantt @ngul @mario-paniccia @jenkins-reform-hmcts2