-
Notifications
You must be signed in to change notification settings - Fork 186
feat: add Explicit bucket schemas API #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 90.21% // Head: 90.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 90.21% 90.25% +0.04%
==========================================
Files 39 39
Lines 3412 3427 +15
==========================================
+ Hits 3078 3093 +15
Misses 334 334
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…e column names, tags, fields, and data types for your data.`
|
||
warnings.simplefilter("ignore", CloudOnlyWarning) | ||
""" | ||
warnings.warn(message, CloudOnlyWarning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means users who are using this with cloud suddenly will get additional text for every usage correct? That seems less than ideal to make a user who is using this correctly to need to ignore a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I will add a checking to the type of instance before warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of warning is changed. The warnings are displayed on individual actions and only if the InfluxD instance is not Cloud. For more info see:
def _is_cloud_instance(self) -> bool: if not self._is_cloud_instance():
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing up the warning. I haven't gone through all the API generated code, only the logic and warnings changes that were added.
@powersj thanks for review. The generated code mainly contains only initialization of the base class. |
Closes #525
Proposed Changes
BucketSchemas
,InvokableScripts
. The following code:Checklist
pytest tests
completes successfully