Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add Explicit bucket schemas API #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Explicit bucket schemas API #528
Changes from all commits
b057ca2
9b8e182
6b91b07
9d952df
c963e76
cffd55a
509cccd
b102dc3
193a459
d2ab4d7
38fc35c
62ba5f7
bab51a4
9767ef0
e705ee9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means users who are using this with cloud suddenly will get additional text for every usage correct? That seems less than ideal to make a user who is using this correctly to need to ignore a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I will add a checking to the type of instance before warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of warning is changed. The warnings are displayed on individual actions and only if the InfluxD instance is not Cloud. For more info see:
influxdb-client-python/influxdb_client/service/_base_service.py
Line 28 in e705ee9
influxdb-client-python/influxdb_client/service/bucket_schemas_service.py
Line 75 in e705ee9