Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-299] Remove field accessors for GenesisConfiguration data type #2900

Closed
wants to merge 1 commit into from

Conversation

Jimbo4350
Copy link
Contributor

Description

Remove field accessors for GenesisConfiguration data type

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-299

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@Jimbo4350 Jimbo4350 requested a review from erikd as a code owner May 9, 2018 14:56
@erikd
Copy link
Member

erikd commented May 9, 2018

Chatted to Jordan about this. We need to add some tests before we dive into things that can change the derived serialisation formats (JSON and binary).

Closing the PR and may create a new one later.

@erikd erikd closed this May 9, 2018
@Jimbo4350
Copy link
Contributor Author

New PR at #3140

@jcmincke jcmincke changed the title Remove field accessors for GenesisConfiguration data type [CDEC-299] Remove field accessors for GenesisConfiguration data type Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants