Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Remove field accessors from GenesisConfiguration #3140

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

Jimbo4350
Copy link
Contributor

Description

Remove field accessors from GenesisConfiguration

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-299

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@Jimbo4350 Jimbo4350 requested review from erikd, mhuesch and ruhatch June 26, 2018 16:26
Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - they weren't even using these ones 🤦‍♂️

@Jimbo4350 Jimbo4350 removed request for erikd and mhuesch June 26, 2018 17:14
Copy link
Contributor

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious, why the small PR? Aren't there other partial functions in core that could now disappear? Or is that blocked on switching to deriveIndexedBi?

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Jun 26, 2018

I thought there would be partial functions to remove but they weren't using these accessors anywhere in the repo!

@erikd
Copy link
Member

erikd commented Jun 26, 2018

Failed due to:

    C:\w\wallet-new\src\Cardano\Wallet\WalletLayer\Kernel.hs:30:1: error:
        Could not find module `Pos.Util.BackupPhrase'
        Use -v to see a list of the files searched for.
       |
    30 | import           Pos.Util.BackupPhrase
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I've got a fix for that in #3135 .

Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Winning!

@Jimbo4350 Jimbo4350 merged commit f673733 into develop Jun 28, 2018
@Jimbo4350 Jimbo4350 deleted the jordan/CDEC-299 branch June 28, 2018 13:47
@rvl
Copy link
Contributor

rvl commented Jul 2, 2018

I think this change breaks a FromJSON instance.

cardano-node: ConfigurationParseFailure "/nix/store/n1l77r7gaals3ssbhprlqn4b9c9bwd5b-cardano-sl-config/lib/configuration.yaml" (AesonException "Error in $['mainnet_staging_short_epoch_wallet_win64'].core.genesis: When parsing the constructor GCSrc of type Pos.Core.Configuration.Core.GenesisConfiguration expected Array but got Object.")

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants