-
Notifications
You must be signed in to change notification settings - Fork 631
Remove field accessors from GenesisConfiguration
#3140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - they weren't even using these ones 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just curious, why the small PR? Aren't there other partial functions in core that could now disappear? Or is that blocked on switching to deriveIndexedBi
?
I thought there would be partial functions to remove but they weren't using these accessors anywhere in the repo! |
Failed due to:
I've got a fix for that in #3135 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Winning!
I think this change breaks a
|
Description
Remove field accessors from
GenesisConfiguration
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-299
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)