This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Revert "[CDEC-299] Remove field accessors for GenesisConfiguration"
#3172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b258f92.
rvl
approved these changes
Jul 2, 2018
|
@rvl @disassembler Yikes, sorry we broke that! Good call to revert it. If we re-remove the partial function field accessors we'll rewrite the JSON instances to make sure they are backwards compatible. Are there tests that we should've run to catch the regression? cc/ @Jimbo4350 |
|
Hydra was out of action for a little bit last week and this is where the wallet integration tests get run. |
|
Apologies guys! |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b258f92 from PR #3140.
The record fields are used for parsing of
lib/configuration.yaml.