This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-405] #3175
Merged
[CDEC-405] #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
previously requested changes
Jul 3, 2018
lib/configuration.yaml
Outdated
| file: mainnet-genesis.json | ||
| hash: 5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb | ||
| - mainnet-genesis.json | ||
| - 5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb |
There was a problem hiding this comment.
I suspect that is wrong, or rather that there should not be any change to that file. Commit b258f92 changed the way the config was parsed and has since been reverted.
You can probably drop these changes to this file and still have the test pass (as long as you have rebased).
|
@erikd, @parsonsmatt, @avieth any chance for taking a look at this tiny PR. |
Like `withConfigurations` but takes explicit `LoggerName` argument. This is useful when one wants to run a computation in `IO` where `WithLogger` instance is not available.
erikd
approved these changes
Jul 3, 2018
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This solves the recent problem with
lib/configuration.yamlnot being parsable anymore. This happend because core team rightly removed some partial accessor functions. I just updated the yaml file and I alsoI added a test. This is a short term solution, long term I think we should writeFromJSONinstances for the types we are reading, because just removing fields from config file will make it less and less readable. @erikd it's up to you to decide if this maintainingFromJSONinstances is worth the effort vs readability of the config file. I guess this really depends how many more partial functions we will remove.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-405
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)