Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-285] Remove field accessors for FakeTxsHistory data type #3168

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

Jimbo4350
Copy link
Contributor

Description

Remove field accessors for FakeTxsHistory data type

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-285

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@Jimbo4350 Jimbo4350 requested review from erikd, mhuesch and intricate July 1, 2018 17:54
coot
coot previously requested changes Jul 1, 2018
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small style change to do.

@Jimbo4350 Jimbo4350 force-pushed the jordan/CDEC-285 branch 2 times, most recently from c70adb3 to 4a148f8 Compare July 2, 2018 00:15
Copy link
Contributor

@intricate intricate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the file pkgs/default.nix.new added by mistake?

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Jul 5, 2018

After breaking the cardano node in #3140, we are currently writing tests for GenesisConfiguration to be sure we don't do this again. Once we are finished with GenesisConfiguration, we will come back to FakeTxsHistory. Do not merge this branch.

https://iohk.myjetbrains.com/youtrack/issue/CDEC-404

@coot
Copy link
Contributor

coot commented Jul 5, 2018

@Jimbo4350 note that I added a test for parsing lib/configuration.yaml in #3175

@jcmincke jcmincke changed the title Remove field accessors for FakeTxsHistory data type [CDEC-285] Remove field accessors for FakeTxsHistory data type Jul 5, 2018
@erikd erikd dismissed coot’s stale review July 9, 2018 07:11

Jordan has fixed it.

@erikd erikd merged commit 0a32da1 into develop Jul 9, 2018
@Jimbo4350 Jimbo4350 deleted the jordan/CDEC-285 branch July 20, 2018 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants