Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[RCD-28] handle IOExceptions in retrievalWorker #3294

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Jul 24, 2018

Description

This PR adds IOException handler in retrievalWorker.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/RCD-28

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@coot coot requested review from avieth, dcoutts and erikd as code owners July 24, 2018 11:02
dcoutts
dcoutts previously approved these changes Jul 24, 2018
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dcoutts
dcoutts previously approved these changes Jul 24, 2018
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

@tatyanavych
Copy link
Contributor

release/1.3.0 is done. This should be merged to release/1.3.1

@darko-mijic
Copy link
Contributor

@coot, please provide a better title for this PR.

@coot coot changed the title [RCD-28] [RCD-28] handle IOExceptions in retrievalWorker Aug 20, 2018
@coot
Copy link
Contributor Author

coot commented Aug 20, 2018

@darko-mijic done

@coot coot changed the base branch from release/1.3.0 to release/1.3.1 August 21, 2018 10:07
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

@coot coot removed the DO NOT MERGE label Aug 21, 2018
@rvl rvl merged commit 89ab6a6 into release/1.3.1 Aug 22, 2018
@coot
Copy link
Contributor Author

coot commented Aug 22, 2018

Thanks @rvl .

@coot coot deleted the coot/rcd-28 branch January 22, 2019 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants