Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[RCD-28] cherry pick fix from release/1.3.1 #3711

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 4, 2018

Description

Cherry pick two commits from release/1.3.1 branch which fixed RCD-28. It was merged to release/1.3.1 branch in this PR

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/RCD-28

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@coot coot requested review from dcoutts and erikd October 4, 2018 14:47
@coot
Copy link
Contributor Author

coot commented Oct 4, 2018

@duncan you already approved this PR once to release/1.3.1;

@coot coot changed the title Coot/rcd 28 to develop [RCD-28] to develop Oct 4, 2018
@coot coot changed the title [RCD-28] to develop [RCD-28] cherry pick fix from release/1.3.1 Oct 4, 2018
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coot coot merged commit 7d825a2 into develop Oct 5, 2018
@coot coot deleted the coot/rcd-28-to-develop branch October 5, 2018 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants