This repository was archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 631
[CO-405] Remove old wallet code from API.V1.Types #3688
Merged
KtorZ
merged 2 commits into
CO-372/TheGreatCleanup
from
matt/co-405/remove-from-api-types
Oct 1, 2018
Merged
[CO-405] Remove old wallet code from API.V1.Types #3688
KtorZ
merged 2 commits into
CO-372/TheGreatCleanup
from
matt/co-405/remove-from-api-types
Oct 1, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no golden test. It's unnecessary as the ToJSON and FromJSON instances did not touch that part of the constructor at all -- they unpacked it and worked with the block count directly. |
cece326
to
b58cd69
Compare
KtorZ
approved these changes
Sep 28, 2018
akegalj
approved these changes
Sep 29, 2018
KtorZ
added a commit
that referenced
this pull request
Oct 1, 2018
…-api-types [CO-405] Remove old wallet code from API.V1.Types
KtorZ
added a commit
that referenced
this pull request
Oct 2, 2018
…-api-types [CO-405] Remove old wallet code from API.V1.Types
KtorZ
added a commit
that referenced
this pull request
Oct 3, 2018
…-api-types [CO-405] Remove old wallet code from API.V1.Types
KtorZ
added a commit
that referenced
this pull request
Oct 4, 2018
…-api-types [CO-405] Remove old wallet code from API.V1.Types
KtorZ
added a commit
that referenced
this pull request
Oct 8, 2018
…-api-types [CO-405] Remove old wallet code from API.V1.Types
KtorZ
added a commit
that referenced
this pull request
Oct 11, 2018
KtorZ
added a commit
that referenced
this pull request
Oct 22, 2018
KtorZ
added a commit
that referenced
this pull request
Oct 31, 2018
KtorZ
added a commit
that referenced
this pull request
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
[CO-405]
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)