Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CO-405] Remove old wallet code from API.V1.Types #3688

Merged
merged 2 commits into from
Oct 1, 2018

Conversation

parsonsmatt
Copy link
Contributor

@parsonsmatt parsonsmatt commented Sep 28, 2018

Description

Linked issue

[CO-405]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@parsonsmatt
Copy link
Contributor Author

There's no golden test. It's unnecessary as the ToJSON and FromJSON instances did not touch that part of the constructor at all -- they unpacked it and worked with the block count directly.

@parsonsmatt parsonsmatt force-pushed the matt/co-405/remove-from-api-types branch from cece326 to b58cd69 Compare September 28, 2018 21:37
@KtorZ KtorZ merged commit 5ad1726 into CO-372/TheGreatCleanup Oct 1, 2018
@KtorZ KtorZ deleted the matt/co-405/remove-from-api-types branch October 1, 2018 08:28
KtorZ added a commit that referenced this pull request Oct 1, 2018
…-api-types

[CO-405] Remove old wallet code from API.V1.Types
@KtorZ KtorZ mentioned this pull request Oct 1, 2018
12 tasks
KtorZ added a commit that referenced this pull request Oct 2, 2018
…-api-types

[CO-405] Remove old wallet code from API.V1.Types
KtorZ added a commit that referenced this pull request Oct 3, 2018
…-api-types

[CO-405] Remove old wallet code from API.V1.Types
KtorZ added a commit that referenced this pull request Oct 4, 2018
…-api-types

[CO-405] Remove old wallet code from API.V1.Types
KtorZ added a commit that referenced this pull request Oct 8, 2018
…-api-types

[CO-405] Remove old wallet code from API.V1.Types
KtorZ added a commit that referenced this pull request Oct 11, 2018
KtorZ added a commit that referenced this pull request Oct 22, 2018
KtorZ added a commit that referenced this pull request Oct 31, 2018
KtorZ added a commit that referenced this pull request Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants