This repository was archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ebf508
to
ebde06f
Compare
1626f65
to
dff5f45
Compare
f9250d0
to
74a975f
Compare
74a975f
to
b6c0d9a
Compare
Let's start to clean this stuff out. We've a fresh new wallet now, this isn't needed anymore
Also move MnemonicSpec.hs
- Remove references to V0 API - Use RecordWildCards instead of huge tuple
It had a laudable goal, was mangled and eventually bit-rotted. It's not used anymore and heavily rely on V0 and legacy data-layer code. R.I.P
…heGreatCleanup
…TheGreatCleanup
…2/TheGreatCleanup
b6c0d9a
to
c27cc6b
Compare
12 tasks
We want to remove `wallet` as a dependency to `wallet-new`. This commit also moves `WAddressMeta` to `Cardano.Wallet.API.V1.Types`.
….hs from wallet-new [CO-380] Placate hlint
c27cc6b
to
93b77f6
Compare
[CO-413] Relocating NoContent instance and adopt
The goal of CO-372 is to remove the old wallet. This commit removes it from various nix, CI and cabal files without any immediate trouble.
93b77f6
to
78e61b1
Compare
denisshevchenko
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
U/S branch for The Great Cleanup
This aggregates the following PRs (all already reviewed):
[email protected]
to[email protected]
#3663Pos.Wallet.Web.Tracking.Decrypt
#3683wallet
dependency fromCardano/Wallet/Server/Plugins.hs
#3686cardano-sl-wallet
#3750Linked issue
[CO-372]
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)