Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CO-372] The Great Cleanup #3673

Merged
merged 24 commits into from
Nov 2, 2018
Merged

[CO-372] The Great Cleanup #3673

merged 24 commits into from
Nov 2, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Sep 27, 2018

Description

U/S branch for The Great Cleanup

This aggregates the following PRs (all already reviewed):

Linked issue

[CO-372]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@KtorZ KtorZ force-pushed the CO-372/TheGreatCleanup branch 6 times, most recently from 0ebf508 to ebde06f Compare October 4, 2018 06:48
@KtorZ KtorZ force-pushed the CO-372/TheGreatCleanup branch 2 times, most recently from 1626f65 to dff5f45 Compare October 11, 2018 08:37
@KtorZ KtorZ force-pushed the CO-372/TheGreatCleanup branch from f9250d0 to 74a975f Compare October 22, 2018 13:14
@KtorZ KtorZ force-pushed the CO-372/TheGreatCleanup branch from 74a975f to b6c0d9a Compare October 31, 2018 18:11
Anviking and others added 4 commits November 2, 2018 10:26
We want to remove `wallet` as a dependency to `wallet-new`.

This commit also moves `WAddressMeta` to `Cardano.Wallet.API.V1.Types`.
@KtorZ KtorZ force-pushed the CO-372/TheGreatCleanup branch from c27cc6b to 93b77f6 Compare November 2, 2018 09:27
@KtorZ KtorZ force-pushed the CO-372/TheGreatCleanup branch from 93b77f6 to 78e61b1 Compare November 2, 2018 10:31
Copy link

@denisshevchenko denisshevchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@denisshevchenko denisshevchenko merged commit 89374a0 into develop Nov 2, 2018
@denisshevchenko denisshevchenko deleted the CO-372/TheGreatCleanup branch November 2, 2018 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants