Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CO-426] - Follow-up on CO-373 #3738

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Oct 11, 2018

Description

When tackling CO-373, we had to work-around a few things as some instances in the moved module were conflicting with other legacy types not-yet-removed from the code-base.

We now can tackle the rest.

Linked issue

[CO-426]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@KtorZ KtorZ requested a review from Anviking October 11, 2018 09:06
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Same

@@ -31,9 +31,6 @@ module Cardano.Wallet.Kernel.BIP39
, mnemonicToAesKey
, entropyToMnemonic
, entropyToByteString

-- * Helper (FIXME: Move to a separated module)
, eitherToParser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@KtorZ KtorZ merged commit 6adadde into CO-372/TheGreatCleanup Oct 11, 2018
@KtorZ KtorZ deleted the KtorZ/CO-425/follow-up-CO-373 branch October 11, 2018 11:48
@KtorZ KtorZ mentioned this pull request Oct 22, 2018
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants