Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Remove last EOS artifacts from 1.5 #4046

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Jan 29, 2019

Description

Those ended up on cardano-sl/develop sooner than they should've.
BIP-44 and externally-owned wallet will only be shipped once we
have fully completed the BIP-44 story on cardano-wallet.

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

Those ended up on cardano-sl/develop sooner than they should've.
BIP-44 and externally-owned wallet will only be shipped once we
have fully completed the BIP-44 story on cardano-wallet.
@KtorZ KtorZ requested a review from denisshevchenko January 29, 2019 15:15
@KtorZ
Copy link
Contributor Author

KtorZ commented Jan 29, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 29, 2019
4046: Remove last EOS artifacts from 1.5 r=KtorZ a=KtorZ

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

Those ended up on cardano-sl/develop sooner than they should've.
BIP-44 and externally-owned wallet will only be shipped once we
have fully completed the BIP-44 story on cardano-wallet.

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: KtorZ <[email protected]>
@KtorZ KtorZ self-assigned this Jan 29, 2019
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 29, 2019

@iohk-bors iohk-bors bot merged commit fdae103 into develop Jan 29, 2019
@iohk-bors iohk-bors bot deleted the KtorZ/251/remove-eos-wallets-completely branch January 29, 2019 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants